fix(aws-cloudfront): Fix loggingConfig being ignored#805
fix(aws-cloudfront): Fix loggingConfig being ignored#805ZeldoKavira wants to merge 8 commits intoaws:masterfrom
Conversation
feat(aws-s3): Add support for domainName on BucketRef instead of just Bucket LoggingConfiguration now requires bucket instead of it being optional. There is no point to including a LoggingConfiguration without a bucket (no-breaking). Fixes aws#721
|
I was ready to approve this, but while fixing up the docstrings I noticed that the intended purpose of That still seems like desirable behavior to me, so can you make that work? It involves new'ing up an |
|
Oh and apparently I broke something. Sorry! 👀 |
|
I will take a look at the auto generation! |
Fix whitespace errors with S3 Auto generate logging bucket if one is not provided + tests
|
@rix0rrr Lets pause this one for a second, found a potential issue with CloudFormation |
Export domain name so that it can be referenced by external cloudfronts
|
@rix0rrr Resolved the issue. |
Update cloudfront testing
|
@rix0rrr Fixed merge issue from the other PR being accepted, if possible can you cut a release after this PR is accepted? |
|
I messed up and overlooked export(), reverting to a different branch to keep the commits clean |
2 participants
feat(aws-s3): Add support for domainName on BucketRef instead of just Bucket
Fixes #721
Note: I know this goes against the policy of one fix/feature/ect per PR, but the s3 feature was required to complete this PR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.